Preserve original PDB path in Debug header #183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing debug symbols, Cecil places them into a
.pdb
file adjacent to the.dll
in the output. It also uses the path of this output.pdb
as the path to the PDB in the.dll
's CodeView Debug Directory entry, which breaks scenarios usingPathMap
.This change fixes the PDB path in the CodeView Debug Directory entry to preserve the original path if it was present in the input
.dll
(but doesn't otherwise affect where Cecil looks for or writes out.pdb
files).Fixes dotnet/runtime#99594.