[release/10.0-preview1] Do not remove wixpacks from items to sign #60523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They need to be in the list so that they are identified as the pack for an msi or exe that can be unpacked, signed, and then used to re-create the msi/exe.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
wtgodbe
approved these changes
Feb 20, 2025
|
/backport to main |
|
/backport to release/10.0-preview2 |
|
Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/13442027301 |
|
Started backporting to release/10.0-preview2: https://github.com/dotnet/aspnetcore/actions/runs/13442029357 |
This was referenced Feb 20, 2025
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They need to be in the list so that they are identified as the pack for an msi or exe that can be unpacked, signed, and then used to re-create the msi/exe.