-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Problem Details casing bug (#59396) #59876
Conversation
@dotnet-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making this contribution! 🙇🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs:59
- The variable name 'tradeIdKeyName' appears to be a typo. It should be renamed to 'traceIdKeyName'.
var tradeIdKeyName = _serializerOptions.PropertyNamingPolicy?.ConvertName("traceId") ?? "traceId";
Sure no problem it was fun! |
Problem Details casing bug (#59396)
Summary of the changes (Less than 80 chars)
Fixes bug #59396
Made recommended changes and created unit tests to verify that changes match intended result for traceId.
Fixes #{bug number} (in this specific format)