Avoid null refs in HotReloadAgent when accessing Assembly.Modules #33263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing Assembly.Modules for arbitrary loaded assemblies may throw which currently results in the hot reload agent to produce an unhandled exception crashing the app. This change attempts to perform a targeted fix for that issue. Fixes #33152
TanayParikh
reviewed
Jun 3, 2021
| @@ -39,7 +39,7 @@ private void OnAssemblyLoad(object? _, AssemblyLoadEventArgs eventArgs) | |||
| if (_deltas.TryGetValue(moduleId.Value, out var updateDeltas) && _appliedAssemblies.TryAdd(loadedAssembly, loadedAssembly)) | |||
There was a problem hiding this comment.
Do we use a ConcurrentDictionary<Assembly, Assembly> instead of a ConcurrentBag to protect against duplicate entries?
There was a problem hiding this comment.
We really need a ConcurrentSet here. ConcurrentBags have no lookup semantics, it gives you an item with no good way of telling you if a specific instance exists. ConcurrentDictionary with a throw away value acts as a reasonable subsitute.
captainsafia
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing Assembly.Modules for arbitrary loaded assemblies may throw which currently results
in the hot reload agent to produce an unhandled exception crashing the app. This change attempts
to perform a targeted fix for that issue.
Fixes #33152