Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MVC's homebrew transcoding stream with System.Text.Encoding.CreateTranscodingStream #21243

Closed
pranavkm opened this issue Apr 27, 2020 · 3 comments · Fixed by #21509
Closed

Replace MVC's homebrew transcoding stream with System.Text.Encoding.CreateTranscodingStream #21243

pranavkm opened this issue Apr 27, 2020 · 3 comments · Fixed by #21509
Assignees
@pranavkm
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Milestone
5.0.0-preview5

Comments

@pranavkm
Copy link
Contributor

Once dotnet/runtime#30260 is resolved
@pranavkm pranavkm added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates blocked The work on this issue is blocked due to some dependency labels Apr 27, 2020
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Apr 28, 2020
@GrabYourPitchforks
Copy link
Member

The new API is now in.

@pranavkm
Copy link
Contributor Author

Thanks. Waiting for a runtime update to update this.

@rynowak
Copy link
Member

rynowak commented May 1, 2020

This is dream come true. 😍 Thanks @GrabYourPitchforks 😍

pranavkm added a commit that referenced this issue May 5, 2020
@pranavkm
Use Encoding.CreateTranscodingStream
1d8d330 
Fixes #21243
@pranavkm pranavkm mentioned this issue May 5, 2020
Merged
pranavkm added a commit that referenced this issue May 6, 2020
@pranavkm
Use Encoding.CreateTranscodingStream
1c3fe5c 
Fixes #21243
pranavkm added a commit that referenced this issue May 6, 2020
@pranavkm
Use Encoding.CreateTranscodingStream (#21509)
51f18b5 
* Use Encoding.CreateTranscodingStream

Fixes #21243
@pranavkm pranavkm self-assigned this May 7, 2020
@pranavkm pranavkm removed the blocked The work on this issue is blocked due to some dependency label May 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview5
Development

Successfully merging a pull request may close this issue.

Use Encoding.CreateTranscodingStream dotnet/aspnetcore
4 participants
@pranavkm @rynowak @GrabYourPitchforks @mkArtakMSFT