-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full .NET SDK to run XHarness (temporarily) #7788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@riarenas / @alexperovich do you think you could merge this in case you get to it and you approve? Thanks! |
riarenas
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine to me, but I'd like to see whether @alexperovich has any concerns or ideas for this.
alexperovich
approved these changes
Aug 25, 2021
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 27, 2021
Fixes an issue with mismatched dotnet SDK versions we're hitting in runtime-staging on mobile platforms (see dotnet/arcade#7788)
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Aug 27, 2021
Fixes an issue with mismatched dotnet SDK versions we're hitting in runtime-staging on mobile platforms (see dotnet/arcade#7788)
stephentoub
pushed a commit
to dotnet/runtime
that referenced
this pull request
Aug 28, 2021
Fixes an issue with mismatched dotnet SDK versions we're hitting in runtime-staging on mobile platforms (see dotnet/arcade#7788)
mdh1418
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 3, 2021
…57208) * [MacCatalyst][Libraries] Reenable MacCatalyst x64 crashing test suites * [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites * Temporarily enable MacCatalyst arm64 lane * Readd consistently crashing suites to iOS tvOS MacCatalyst skips * Address crashes and PNSE failures on iOS MacCatalyst * Temporarily bump timeout for tvOS * fix typo * Skip more crashed suites * Undo temporary changes and Add ActiveIssue * Skip more crashing suites * Skip iOS.Simulator.Aot.Test flake on MacCatalyst CI * Add a couple crashing suites * Remove sample skip in tests.proj as it doesnt do anything * Add another flakey crashed test for MacCatalyst * Skip System.Xml.Xsl.XslCompiledTransformApi on MacCatalyst * Temporarily remove test suite skips and enable arm64 lanes and bump lane timeout to evaluate crashes * Reenable a test that was fixed * Update Microsoft.DotNet.Helix.Sdk Fixes an issue with mismatched dotnet SDK versions we're hitting in runtime-staging on mobile platforms (see dotnet/arcade#7788) * [iOS] Skip ValidAccessLevelCombinations ReadWriteExecute for iOSSimulator arm64 * Skip failing test suites * Extend trampoline bump to iOS tvOS MacCatalyst * Fixup typo * Fix MonoAOTCompiler typo * Bump trampolines for osxlike lanes * Add active issues for failing tests * Remove ActiveIssue that was fixed * Add IsIanaIdTest skip * Bump trampolines even higher * Address feedback * Fix typo * Undo runtime-staging temporary changes and cleanup test skips * Fix path typo * Skip iOS sample * Add new activeIssue and skip flakey Android test crash * Skip functional tests crashing with exit code 0 Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7787