Update the SDK to 6.0 Preview 1 #6975

ViktorHofer · 2021-02-18T16:06:23Z

As agreed in Tactics, we want to dogfood our officially released SDK builds on a monthly cadence. Also sent out a mail to tactics for approval.

To double check:

The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/core-eng/tree/master/Documentation/Validation

ViktorHofer · 2021-02-18T19:12:14Z

@mmitche any idea what's causing the failure?

ViktorHofer · 2021-02-20T10:20:35Z

/azp run arcade-ci

azure-pipelines · 2021-02-20T10:20:45Z

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer · 2021-02-20T10:22:14Z

Had to update the NuGet package dependencies because of a breaking change in their API: NuGet/NuGet.Client#3215 (comment).

ViktorHofer · 2021-02-20T12:16:42Z

/azp run arcade-ci

azure-pipelines · 2021-02-20T12:16:58Z

Azure Pipelines successfully started running 1 pipeline(s).

Lodewijk1 · 2021-02-20T15:21:24Z

Leunin proces. Syst.m 32 windows advanced instller

Lodewijk1 · 2021-02-20T15:42:49Z

Be happy het antwoorx op metox das metox! Op za 20 feb. 2021 13:17 schreef azure-pipelines[bot] < notifications@github.com>:

…

Azure Pipelines successfully started running 1 pipeline(s). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6975 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQJF5LUM4ZRXJP66YIYQK4TS76R5NANCNFSM4X2SC5YA> .

ViktorHofer · 2021-02-23T16:02:39Z

@dotnet/dnceng can someone please help me figuring out why the FindDotNetCliPackage task is failing on the xHarness legs?

premun · 2021-02-23T16:03:58Z

@ViktorHofer let me see

mmitche · 2021-02-23T16:08:05Z

@premun That's not the version of aspnetcore in preview 1 (is actually 6.0.0-preview.1.21103.6)

premun · 2021-02-23T16:12:38Z

So the problem is that XHarness is a .NET Core 3.1 tool and the version was hardcoded to 3.1.5. But then it was changed here:
38a3674

@steveisok I have only seen the other change where you require the aspnetcore-sdk instead of runtime if it's desired. Why did we need to also change the version? This SDK should be only used to run XHarness or there are other things like the web server in the WASM flows?

mmitche · 2021-02-23T16:14:43Z

That change may be getting rolled out to arcade here: #7005

premun · 2021-02-23T16:21:34Z

The value gets set here:

arcade/src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.props

Lines 5 to 6 in f388f25

    
           <DotNetCliVersion Condition=" '$(DotNetCliVersion)' == '' AND '$(DotNetCliPackageType)' == 'runtime' ">$(BundledNETCoreAppPackageVersion)</DotNetCliVersion> 
        
           <DotNetCliVersion Condition=" '$(DotNetCliVersion)' == '' AND '$(DotNetCliPackageType)' == 'aspnetcore-runtime' ">$(BundledNETCoreAppPackageVersion)</DotNetCliVersion>

If we have incoherent preview versions between the SDK and the ASP.NET Core version, we might need to have two variables then but I am not sure about the impact of a change like that.

mmitche · 2021-02-23T16:30:36Z

The value gets set here:

arcade/src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.props

Lines 5 to 6 in f388f25

<DotNetCliVersion Condition=" '$(DotNetCliVersion)' == '' AND '$(DotNetCliPackageType)' == 'runtime' ">$(BundledNETCoreAppPackageVersion)</DotNetCliVersion>

<DotNetCliVersion Condition=" '$(DotNetCliVersion)' == '' AND '$(DotNetCliPackageType)' == 'aspnetcore-runtime' ">$(BundledNETCoreAppPackageVersion)</DotNetCliVersion>

If we have incoherent preview versions between the SDK and the ASP.NET Core version, we might need to have two variables then but I am not sure about the impact of a change like that.

It's safe to assume that we will have incoherent versions for every preview, and coherent for any RTM/servicing version.

premun · 2021-02-24T10:19:55Z

@ViktorHofer how urgent is this update? I am a bit burried this week but I could look into it next week

ViktorHofer · 2021-02-24T11:52:36Z

It would be really great to get this in before Monday 3/1 which is the date when we update the SDK in dotnet/runtime as part of our batched rollout.

premun · 2021-02-24T12:00:50Z

I will have a look on Friday then. I need to make sure a change here won't cause problems down the line first so I don't want to rush it much.

But please be aware that this probably only changes which .NET we use to build Arcade. The projects themselves have only recently been updated to .NET Core 3.1 (#6891). So the produces of Arcade are behind quite a lot.

ViktorHofer · 2021-02-24T17:35:20Z

But please be aware that this probably only changes which .NET we use to build Arcade. The projects themselves have only recently been updated to .NET Core 3.1 (#6891). So the produces of Arcade are behind quite a lot.

That is understood and expected. Even though I think we should always build against latest, the reason why this PR is opened is to flow the SDK update to 6.0 P1 into all "arcadified" repositories. Arcade handles that well as its part of the Maestro dependency flow.

As agreed in Tactics, we want to dogfood our own SDK builds on a monthly cadence. Also sent out a mail to tactics for approval.

premun · 2021-02-25T17:25:14Z

So I actually found that the real problem is different..
The green version is in global.json and the yellow version it's trying to install but cannot find:

/__w/1/s/src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.targets(5,5): Unable to find dotnet cli aspnetcore-runtime version 6.0.0-preview.1.21102.12, tried https://dotnetcli.azureedge.net/dotnet/aspnetcore/Runtime/6.0.0-preview.1.21102.12/aspnetcore-runtime-6.0.0-preview.1.21102.12-osx-x64.tar.gz [/__w/1/s/tests/UnitTests.XHarness.iOS.proj]

mmitche · 2021-02-25T17:29:36Z

@rbhanda @leecow See above, the included runtimes have the same version, but they're different for previews.

rbhanda · 2021-02-25T17:48:41Z

Adding @mairaw for dot.net.

As per the release.json, the ASP.NET Runtime version is 6.0.0-preview.1.21103.6 while runtime version is 6.0.0-preview.1.21102.12.

Also releases.json has the correct URL for aspnetcore-runtime-osx-x64

premun · 2021-02-25T18:11:39Z

Thanks!

So I guess the way we get the URL is wonky in our case:

arcade/src/Microsoft.DotNet.Helix/Sdk/FindDotNetCliPackage.cs

Line 89 in 15246f4

    
           "aspnetcore-runtime" => $"{DotNetCliAzureFeed}/aspnetcore/Runtime/{Version}/aspnetcore-runtime-{Version}-{Runtime}.{extension}",

I guess we should be parsing the release.json and getting it from there?

premun · 2021-02-25T18:14:48Z

@ViktorHofer the build is green now but it forces the specific preview version in a sort-of hacky way. Nonetheless, it should work since it's tied to SDK version set in global.json. If we want this in for Monday, I'd say we can do it and prepare a proper way to handle this.

@mmitche thoughts?

mmitche · 2021-02-25T18:33:54Z

@ViktorHofer the build is green now but it forces the specific preview version in a sort-of hacky way. Nonetheless, it should work since it's tied to SDK version set in global.json. If we want this in for Monday, I'd say we can do it and prepare a proper way to handle this.

@mmitche thoughts?

Yep fine by me. Parsing the releases.json seems questionable. There are times when we don't use officially released versions here.

ViktorHofer · 2021-02-25T23:34:50Z

Yes works for me too. Let's just make sure that the proper fix gets the right attention after this is in. Thanks to all that helped getting this in.

mairaw · 2021-02-26T19:04:33Z

Thanks for the ping @rbhanda. I've fixed the download page info:

* Update the SDK to 6.0 Preview 1 As agreed in Tactics, we want to dogfood our own SDK builds on a monthly cadence. Also sent out a mail to tactics for approval. * Remove default for ASP.NET Core runtime SDK * Hardcode the preview version to unblock ourselves * Force the Preview 1 version even more * Override inside of the XHarness SDK Co-authored-by: Premek Vysoky <premek.vysoky@microsoft.com>

ViktorHofer requested a review from mmitche February 18, 2021 16:06

mmitche approved these changes Feb 18, 2021

View reviewed changes

stephentoub mentioned this pull request Feb 18, 2021

Update analyzers dotnet/runtime#48427

Merged

This comment has been minimized.

Sign in to view

ViktorHofer and others added 2 commits February 25, 2021 11:00

Update the SDK to 6.0 Preview 1

9797266

As agreed in Tactics, we want to dogfood our own SDK builds on a monthly cadence. Also sent out a mail to tactics for approval.

Remove default for ASP.NET Core runtime SDK

870e770

premun force-pushed the ViktorHofer-sdk6.0p1 branch from a890f2f to 870e770 Compare February 25, 2021 10:12

premun mentioned this pull request Feb 25, 2021

Fix setting of the DotNetCliVersion for ASP.NET Core runtime #7022

Closed

2 tasks

Hardcode the preview version to unblock ourselves

89dc7fb

premun requested review from mmitche and riarenas February 25, 2021 14:18

mmitche approved these changes Feb 25, 2021

View reviewed changes

premun added 2 commits February 25, 2021 16:49

Force the Preview 1 version even more

9f0d790

Override inside of the XHarness SDK

7553d37

ViktorHofer merged commit a6b570d into master Feb 25, 2021

ViktorHofer deleted the ViktorHofer-sdk6.0p1 branch February 25, 2021 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the SDK to 6.0 Preview 1 #6975

Update the SDK to 6.0 Preview 1 #6975

ViktorHofer commented Feb 18, 2021 •

edited

Loading

ViktorHofer commented Feb 18, 2021

ViktorHofer commented Feb 20, 2021

azure-pipelines bot commented Feb 20, 2021

ViktorHofer commented Feb 20, 2021

ViktorHofer commented Feb 20, 2021

azure-pipelines bot commented Feb 20, 2021

This comment has been minimized.

Lodewijk1 commented Feb 20, 2021

Lodewijk1 commented Feb 20, 2021 via email

ViktorHofer commented Feb 23, 2021 •

edited

Loading

premun commented Feb 23, 2021

mmitche commented Feb 23, 2021

premun commented Feb 23, 2021

mmitche commented Feb 23, 2021

premun commented Feb 23, 2021 •

edited

Loading

mmitche commented Feb 23, 2021

premun commented Feb 24, 2021

ViktorHofer commented Feb 24, 2021 •

edited

Loading

premun commented Feb 24, 2021 •

edited

Loading

ViktorHofer commented Feb 24, 2021

premun commented Feb 25, 2021

mmitche commented Feb 25, 2021

rbhanda commented Feb 25, 2021

premun commented Feb 25, 2021

premun commented Feb 25, 2021

mmitche commented Feb 25, 2021

ViktorHofer commented Feb 25, 2021

mairaw commented Feb 26, 2021

Update the SDK to 6.0 Preview 1 #6975

Update the SDK to 6.0 Preview 1 #6975

Conversation

ViktorHofer commented Feb 18, 2021 • edited Loading

To double check:

ViktorHofer commented Feb 18, 2021

ViktorHofer commented Feb 20, 2021

azure-pipelines bot commented Feb 20, 2021

ViktorHofer commented Feb 20, 2021

ViktorHofer commented Feb 20, 2021

azure-pipelines bot commented Feb 20, 2021

This comment has been minimized.

Lodewijk1 commented Feb 20, 2021

Lodewijk1 commented Feb 20, 2021 via email

ViktorHofer commented Feb 23, 2021 • edited Loading

premun commented Feb 23, 2021

mmitche commented Feb 23, 2021

premun commented Feb 23, 2021

mmitche commented Feb 23, 2021

premun commented Feb 23, 2021 • edited Loading

mmitche commented Feb 23, 2021

premun commented Feb 24, 2021

ViktorHofer commented Feb 24, 2021 • edited Loading

premun commented Feb 24, 2021 • edited Loading

ViktorHofer commented Feb 24, 2021

premun commented Feb 25, 2021

mmitche commented Feb 25, 2021

rbhanda commented Feb 25, 2021

premun commented Feb 25, 2021

premun commented Feb 25, 2021

mmitche commented Feb 25, 2021

ViktorHofer commented Feb 25, 2021

mairaw commented Feb 26, 2021

ViktorHofer commented Feb 18, 2021 •

edited

Loading

ViktorHofer commented Feb 23, 2021 •

edited

Loading

premun commented Feb 23, 2021 •

edited

Loading

ViktorHofer commented Feb 24, 2021 •

edited

Loading

premun commented Feb 24, 2021 •

edited

Loading