Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable strong name signing #15556

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Disable strong name signing #15556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@
<RepositoryUrl>https://github.com/dotnet/arcade</RepositoryUrl>
<!-- Only upgrade NuGetAudit warnings to errors for official builds. -->
<WarningsNotAsErrors Condition="'$(OfficialBuild)' != 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
<!--
Arcade does not contribute any artifacts that will be redisted by shipping packages in other components
while building the VMR. Therefore, we can safely skip signing the artifacts.
-->
<SignAssembly>false</SignAssembly>
</PropertyGroup>

</Project>
1 change: 0 additions & 1 deletion src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<TargetFrameworks>$(NetToolCurrent);$(NetFrameworkToolCurrent)</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<SignAssembly>true</SignAssembly>
<Description>This package provides support for publishing assets to appropriate channels.</Description>
<DevelopmentDependency>true</DevelopmentDependency>
<IsBuildTaskProject>true</IsBuildTaskProject>
Expand Down
1 change: 0 additions & 1 deletion ...ft.DotNet.Build.Tasks.Packaging/tests/Microsoft.DotNet.Build.Tasks.Packaging.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFrameworks>$(NetToolCurrent);$(NetFrameworkToolCurrent)</TargetFrameworks>
<SignAssembly>false</SignAssembly>
<NoWarn>$(NoWarn);xUnit2013</NoWarn>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.DotNet.Git.IssueManager/src/Microsoft.DotNet.Git.IssueManager.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFrameworks>$(NetMinimum);$(NetFrameworkMinimum)</TargetFrameworks>
<SignAssembly>false</SignAssembly>
<IsPackable>true</IsPackable>
<ExcludeFromSourceOnlyBuild>true</ExcludeFromSourceOnlyBuild>
</PropertyGroup>
Expand Down
8 changes: 0 additions & 8 deletions src/Microsoft.DotNet.Helix/JobSender/AssemblyProperties.cs
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions src/Microsoft.DotNet.Helix/JobSender/Microsoft.DotNet.Helix.JobSender.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
<PackageReference Include="Microsoft.Data.OData" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.DotNet.Helix.JobSender.Tests" />
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\Common\Microsoft.Arcade.Common\Microsoft.Arcade.Common.csproj" />
<ProjectReference Include="..\Client\CSharp\Microsoft.DotNet.Helix.Client.csproj" />
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.DotNet.SourceBuild/tests/Microsoft.DotNet.SourceBuild.Tasks.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFramework>$(NetToolCurrent)</TargetFramework>
<SignAssembly>false</SignAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion ...icrosoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<IsPackable>true</IsPackable>
<PackAsTool>true</PackAsTool>
<ToolCommandName>dotnet-swaggergen</ToolCommandName>
<SignAssembly>false</SignAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/SignCheck/Microsoft.SignCheck/Microsoft.DotNet.SignCheckLibrary.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

<PropertyGroup>
<TargetFrameworks>$(NetToolCurrent);$(NetFrameworkMinimum)</TargetFrameworks>
<SignAssembly>false</SignAssembly>
<RootNamespace>Microsoft.SignCheck</RootNamespace>
<!-- This assembly is bundled in the Microsoft.DotNet.SignCheck package and is not mean to be used as a class library package. -->
<IsPackable>false</IsPackable>
Expand Down
1 change: 0 additions & 1 deletion src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<TargetFramework>$(NetFrameworkToolCurrent)</TargetFramework>
<OutputType>Exe</OutputType>
<IsTool>true</IsTool>
<SignAssembly>false</SignAssembly>
<IsPackable>true</IsPackable>
<!-- <NoWarn>$(NoWarn);NU5128</NoWarn> -->
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
Expand Down
1 change: 0 additions & 1 deletion src/SignCheck/SignCheckTask/Microsoft.DotNet.SignCheckTask.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<TargetFrameworks>$(NetToolCurrent);$(NetFrameworkToolCurrent)</TargetFrameworks>
<IsPackable>true</IsPackable>
<SignAssembly>false</SignAssembly>
<IsBuildTaskProject>true</IsBuildTaskProject>
<Description>Build artifact signing validation tool</Description>
<PackageTags>Arcade Signing Validation Tool</PackageTags>
Expand Down
Loading