Add support for environment timeout multiplier in remote operation #15215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements solution suggested in dotnet/runtime#108879
jkotas
reviewed
Nov 4, 2024
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
approved these changes
Nov 5, 2024
ViktorHofer
reviewed
Nov 6, 2024
| /// <summary> | ||
| /// A timeout (milliseconds) after which a wait on a remote operation should be considered a failure. | ||
| /// </summary> | ||
| public static int FailWaitTimeoutMilliseconds |
There was a problem hiding this comment.
Just note that this is a breaking change for whoever used the FailWaitTimeoutMilliseconds constant previously in a constant fashion, i.e. on an attribute. I.e. runtime needs to react to this change: https://github.com/dotnet/runtime/pull/109544/files/8e1114ef84b749149d6810186af9eedb5a5892a9..6f3c71addbe11fc998fbec4477435daaf9efee81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements solution suggested in dotnet/runtime#108879
Part of #84834
cc @dotnet/samsung