Introduce DotNetBuildRepo, DotNetBuild, and DotNetBuildPhase #14369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DotNetBuildRepo (formerly DotNetBuildOuterRepo) is the marker for building the repo in .NET product mode - DotNetBuild is calculated off any of DotNetBuildRepo, DOtNetBuildInnerRepo, and DotNetBuildOrchestrator being true - Factored non-repo layout properties into a new file, RepoDefaults.props, instead of housing these in RepoLayout.props - Used DotNetBuildPhase == 'foo' in some cases where it's simpler to do so.
|
This needs more verification. Not all the switches are totally active yet. For instance, the outer repo switch isn't passed from the orchestrator yet, neither is the orchestrator switch. I added some usages where I know they will be though. |
ViktorHofer
reviewed
Jan 15, 2024
ViktorHofer
reviewed
Jan 15, 2024
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Yes, agreed. You could test this in a local VMR build and make the orchestrator pass the settings in. |
|
I'm doing some last minute testing but I think this is ready to go. Verified that the expected controls are showing up. Also enabled DotNetBuildRepo when we get into source build or vertical build modes, so we can transition off of the control use in those repos. |
MichaelSimons
approved these changes
Jan 17, 2024
|
Verified in a full VMR build. Still needs some additional enabling there but looking good so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce DotNetBuildRepo, DotNetBuild, and DotNetBuildPhase
To double check: