[MSBuildDeviceIntegration] Handle Debugger errors #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
approved these changes
Mar 8, 2023
jonathanpeppers
approved these changes
Mar 9, 2023
1119bb2 to
f18c4e7
Compare
We occasionally see the following errors on CI. ``` Unhandled error launching soft debugger System.AggregateException: One or more errors occurred. (DWP Handshake failed.) ---> System.IO.IOException: DWP Handshake failed. at Mono.Debugger.Soft.Connection.Connect() in /Users/builder/azdo/_work/1/s/xamarin-android/external/debugger-libs/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs:line 1361 at Mono.Debugger.Soft.VirtualMachine.connect() in /Users/builder/azdo/_work/1/s/xamarin-android/external/debugger-libs/Mono.Debugger.Soft/Mono.Debugger.Soft/VirtualMachine.cs:line 381 at Mono.Debugger.Soft.VirtualMachineManager.Connect(Connection transport, StreamReader standardOutput, StreamReader standardError) in /Users/builder/azdo/_work/1/s/xamarin-android/external/debugger-libs/Mono.Debugger.Soft/Mono.Debugger.Soft/VirtualMachineManager.cs:line 353 at Mono.Debugger.Soft.VirtualMachineManager.ConnectInternalAsync(Socket dbg_sock, Socket con_sock, IPEndPoint dbg_ep, IPEndPoint con_ep) in /Users/builder/azdo/_work/1/s/xamarin-android/external/debugger-libs/Mono.Debugger.Soft/Mono.Debugger.Soft/VirtualMachineManager.cs:line 309 --- End of inner exception stack trace --- ``` What is supposed to happen is the test shoud be retried. However according to the NUnit docs (1) the `Retry` attribute won't work if an unhandled exception occurs. So lets handle them, this way the `Retry` ca do its job and re-try the test. [1] https://docs.nunit.org/articles/nunit/writing-tests/attributes/retry.html
f18c4e7 to
e939275
Compare
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 15, 2023
* main: [AOT] provide libc and libm stubs so NDK is not required (dotnet#7475) [MSBuildDeviceIntegration] Handle Debugger errors (dotnet#7864) [ci] Remove separate SmokeTests jobs. (dotnet#7872) Bump to dotnet/installer@cddf8e6 8.0.100-preview.3.23163.4 (dotnet#7885) [Actions] Do not double quote the commit message (dotnet#7887) [Actions] Ensure that the commit message is valid json. (dotnet#7884) [github] Use ".NET Android", not "Android for .NET" (dotnet#7882) Bump `$(AndroidNet7Version)` (dotnet#7883) [ci] Install fewer Android SDK platforms on test agents. (dotnet#7874)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 15, 2023
* main: [AOT] provide libc and libm stubs so NDK is not required (dotnet#7475) [MSBuildDeviceIntegration] Handle Debugger errors (dotnet#7864) [ci] Remove separate SmokeTests jobs. (dotnet#7872) Bump to dotnet/installer@cddf8e6 8.0.100-preview.3.23163.4 (dotnet#7885) [Actions] Do not double quote the commit message (dotnet#7887) [Actions] Ensure that the commit message is valid json. (dotnet#7884) [github] Use ".NET Android", not "Android for .NET" (dotnet#7882) Bump `$(AndroidNet7Version)` (dotnet#7883) [ci] Install fewer Android SDK platforms on test agents. (dotnet#7874)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 15, 2023
* main: [AOT] provide libc and libm stubs so NDK is not required (dotnet#7475) [MSBuildDeviceIntegration] Handle Debugger errors (dotnet#7864) [ci] Remove separate SmokeTests jobs. (dotnet#7872) Bump to dotnet/installer@cddf8e6 8.0.100-preview.3.23163.4 (dotnet#7885) [Actions] Do not double quote the commit message (dotnet#7887) [Actions] Ensure that the commit message is valid json. (dotnet#7884)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally see the following errors on CI.
What is supposed to happen is the test shoud be retried. However according to the NUnit docs (1) the
Retryattribute won't work if an unhandled exception occurs. So lets handle them, this way theRetryca do its job and re-try the test.[1] https://docs.nunit.org/articles/nunit/writing-tests/attributes/retry.html