[tests/Codegen-Binding] Use a variable for the Android SDK in the BuildJavaLibs 'gradlew' invocation #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n BuildJavaLibs
This fixes a 'gradlew' failure which is encountered on Windows only. Unfortunately, the 'gradlew' invocation prefixes the 'sdk.dir' value read from 'local.properties' with the path of the working directory.
As a result, we encounter a failure along the following lines on Windows:
```
* What went wrong:
A problem occurred configuring project ':library'.
> The SDK directory 'C:\Users\xamarinqa\git\xamarin-android\tests\CodeGen-Binding\Xamarin.Android.LibraryProjectZip-LibBinding\java\JavaLib\C:Program Files (x86)Androidandroid-sdk' does not exist
```
This can be avoided by exporting ANDROID_HOME in the Exec portion of the BuildJavaLibs target, rather than writing this information to a file and expecting 'gradlew' to process it correctly.
|
@jonpryor does this seem reasonable? It worked for me locally on both macOS and Windows, and will allow for Codegen tests to compile again on Windows without any major setup hacks required on my end. |
|
LGTM. We should merge if it passes macOS+xbuild PR Build. |
jonpryor
approved these changes
Jul 18, 2017
pjcollins
added a commit
that referenced
this pull request
Jul 19, 2017
…n BuildJavaLibs (#696) This fixes a 'gradlew' failure which is encountered on Windows only. Unfortunately, the 'gradlew' invocation prefixes the 'sdk.dir' value read from 'local.properties' with the path of the working directory. As a result, we encounter a failure along the following lines on Windows: ``` * What went wrong: A problem occurred configuring project ':library'. > The SDK directory 'C:\Users\xamarinqa\git\xamarin-android\tests\CodeGen-Binding\Xamarin.Android.LibraryProjectZip-LibBinding\java\JavaLib\C:Program Files (x86)Androidandroid-sdk' does not exist ``` This can be avoided by exporting ANDROID_HOME in the Exec portion of the BuildJavaLibs target, rather than writing this information to a file and expecting 'gradlew' to process it correctly.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 5, 2020
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1193891 Changes: dotnet/java-interop@afbc5b3...75354b9 * dotnet/java-interop@75354b9f: [Java.Interop] Dispose, *then* Remove (dotnet#708) * dotnet/java-interop@8ea0bb28: [jnimarshalmethod-gen] Localizable errors (dotnet#696)
jonpryor
pushed a commit
that referenced
this pull request
Sep 9, 2020
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1193891 Changes: dotnet/java-interop@afbc5b3...ac914ce * dotnet/java-interop@ac914ce3: [ci] Add DevDiv required Roslyn analyzers, fix errors (#704) * dotnet/java-interop@a98c1ae1: [build] fix env vars causing gradle build error (#705) * dotnet/java-interop@75354b9f: [Java.Interop] Dispose, *then* Remove (#708) * dotnet/java-interop@8ea0bb28: [jnimarshalmethod-gen] Localizable errors (#696) Commit dotnet/java-interop@ac914ce3 moved the location of `NullableAttributes.cs`; update `Xamarin.Android.Tools.JavadocImporter.csproj` appropriately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a 'gradlew' failure which is encountered on Windows only. Unfortunately, the 'gradlew' invocation prefixes the 'sdk.dir' value read from 'local.properties' with the path of the working directory.
As a result, we encounter a failure along the following lines on Windows:
This can be avoided by exporting ANDROID_HOME in the Exec portion of the BuildJavaLibs target, rather than writing this information to a file and expecting 'gradlew' to process it correctly.