[build] JavacSourceVersion JavacTargetVersion Harmonization #4771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #4567
In order to support using JDK 11 to build Xamarin.Android, we need to
consistently use
javac -source 1.8 -target 1.8
~everywhere, becausewe also require
javac --boot-class-path
, and JDK11 doesn't supportjavac --boot-class-path
unless targeting < JDK 1.9:The
<Javac/>
task usejavac --boot-class-path
to compile Javacode, so that Android's
android.jar
provides everything:Harmonize provisioning of
javac -source
andjavac -target
values:Add
$(JavacSourceVersion)
and$(JavacTargetVersion)
MSBuildproperties to
Configuration.props
.Update the
src/manifestmerger
andsrc/r8
builds so that$(JavacSourceVersion)
and$(JavacTargetVersion)
are used tocontrol the
.class
files that they create.Update
build-tools/scripts/Jar.targets
to use the values fromConfiguration.props
, instead of separate values.Fix errant invocations of
javac -target $(JavacSourceVersion)
,which should be
javac -target $(JavacTargetVersion)
.