Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Commit 1d38470 worked, in that we no longer get insta-crashes on Windows! The `System.Runtime.CompilerServices.Unsafe` crash was fixed! We now turn our attention to the XA0102 warnings, which are *also* responsible for errors in `BuildReleaseArm64()`, because the `.apk` size now differs, because the icons are now larger; `.apk` size increased by 31,744 bytes! …which is why SixLabors.ImageSharp was used… Avoid SixLabors.ImageSharp and instead have `Xamarin.ProjectTools` use the same icons as the `dotnet new android` template, in `src\Microsoft.Android.Templates\android\Resources\**\appicon.png`. In order to ensure sane `%(LogicalName)` values, `%(RecrusiveDir)` is used as part of the logical name, resulting in resource names on macOS such as: * `mipmap-hdpi/appicon.png` * `mipmap-mdpi/appicon.png` * `mipmap-xhdpi/appicon.png` * `mipmap-xxhdpi/appicon.png` * `mipmap-xxxhdpi/appicon.png` I'm not sure what Windows will do offhand, so have Xamarin.ProjectTools.dll *also* look for a resource name with `/` replaced by `\` (`Path.DirectorySeparatorChar`) so that this logic *should* work on Windows as well. Hopefully this will resolve the XA0102 warnings and the `BuildReleaseArm64()` errors.
- Loading branch information