Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support special casing with Fabric endpoints #3084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support special casing with Fabric endpoints #3084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,16 +750,20 @@ internal static Version GetAssemblyVersion()

private const string ONDEMAND_PREFIX = "-ondemand";
private const string AZURE_SYNAPSE = "-ondemand.sql.azuresynapse.";
private const string FABRIC_DATAWAREHOUSE = ".datawarehouse.fabric.microsoft.com";

internal static bool IsAzureSynapseOnDemandEndpoint(string dataSource)
{
return IsEndpoint(dataSource, ONDEMAND_PREFIX) || dataSource.Contains(AZURE_SYNAPSE);
return IsEndpoint(dataSource, ONDEMAND_PREFIX)
|| dataSource.Contains(AZURE_SYNAPSE)
|| dataSource.Contains(FABRIC_DATAWAREHOUSE);
}

internal static readonly string[] s_azureSqlServerEndpoints = { StringsHelper.GetString(Strings.AZURESQL_GenericEndpoint),
StringsHelper.GetString(Strings.AZURESQL_GermanEndpoint),
StringsHelper.GetString(Strings.AZURESQL_UsGovEndpoint),
StringsHelper.GetString(Strings.AZURESQL_ChinaEndpoint)};
StringsHelper.GetString(Strings.AZURESQL_ChinaEndpoint),
".database.fabric.microsoft.com"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be a resource string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wonder why the other ones are resource strings, I guess they are not localized ?


internal static bool IsAzureSqlServerEndpoint(string dataSource)
{
Expand Down
Loading