Fix nullability annotations of OpenXmlComparableSimpleReference #953
Conversation
| @@ -94,26 +94,28 @@ public override bool Equals(object? obj) | |||
| { | |||
| return false; | |||
| } | |||
| else if (Value is null) | |||
|
|
|||
| if (Value is null) | |||
There was a problem hiding this comment.
It's not required (see the return false above).
|
/azp run |
|
|
|
@twsouthwick, that's interesting. I did not get those errors when running the unit tests on my machine. How did you run those unit tests against those legacy frameworks? They are not run when using the Test Explorer or ReSharper. |
|
@twsouthwick, please re-run the tests. I hope I fixed them but couldn't verify that it works with .NET Framework 3.5, for example. |
|
/azp run |
|
@ThomasBarnekow Check out https://github.com/OfficeDev/Open-XML-SDK/blob/main/CONTRIBUTING.md#building for details on running tests for all platforms. It causes memory issues to load all versions of the project by default, so I separated out a while back. Maybe with VS 2022 being 64-bit that won't be as big of a deal. |
This PR fixes #933.