-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .NET 3.5, .NET 4.0, and .NET 4.6 #185
Conversation
133d1c8
to
8422928
Compare
Looks like the |
I assume that does not impact people targeting 4.5.x in any way, right? On a somewhat related note, does anybody know whether there are .NET Framework "deployment statistics". For example, the question is what percentage of corporate desktop PCs have .NET Framework 4.6.x installed. Google provides information regarding the percentage of Android devices using which Android release, so you can decide which one you would want to target in order to capture whatever percentage of the market. |
@ThomasBarnekow, this won't affect 4.5.x in any way. However, if you target 4.6, you'll get the updated |
@ThomasBarnekow, They are also present on other OSes windows 7 or greater. We don't typically make those numbers public, but if you can explain your need more specifically, I might be able to provide more details. |
@HollyAM, thanks for responding. I will contact you by email to explain what I would need to know. |
This adds target frameworks for more .NET Framework versions, including moving to .NET 4.6 instead of .NET 4.5. That way, .NET 4.6 and later can use System.IO.Packaging, while frameworks below that will have access to the library, but will use WindowsBase.
0d97065
to
f3d77da
Compare
ca85f66
to
9a134a6
Compare
@tomjebo This is ready to review. Thanks! |
@twsouthwick sorry I didn't get to this until now. I decided to leave the two commits separate as they seemed to be logically independent enough. Hope that's ok with you. Thanks for straightening all of this out. |
This adds target frameworks for more .NET Framework versions, including
moving to .NET 4.6 instead of .NET 4.5. That way, .NET 4.6 and later can
use System.IO.Packaging, while frameworks below that will have access to
the library, but will use WindowsBase.
Fixes #180 and #174