Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .NET 3.5, .NET 4.0, and .NET 4.6 #185

Merged
merged 2 commits into from
Apr 24, 2017

Conversation

twsouthwick
Copy link
Member

This adds target frameworks for more .NET Framework versions, including
moving to .NET 4.6 instead of .NET 4.5. That way, .NET 4.6 and later can
use System.IO.Packaging, while frameworks below that will have access to
the library, but will use WindowsBase.

Fixes #180 and #174

@twsouthwick twsouthwick force-pushed the new-targets branch 3 times, most recently from 133d1c8 to 8422928 Compare March 18, 2017 00:51
@twsouthwick
Copy link
Member Author

Looks like the dotnet tool doesn't understand .NET 3.5 reference assemblies. I'll look into switch things to msbuild as that does understand it. See dotnet/msbuild#1333

@ThomasBarnekow
Copy link
Collaborator

I assume that does not impact people targeting 4.5.x in any way, right?

On a somewhat related note, does anybody know whether there are .NET Framework "deployment statistics". For example, the question is what percentage of corporate desktop PCs have .NET Framework 4.6.x installed.

Google provides information regarding the percentage of Android devices using which Android release, so you can decide which one you would want to target in order to capture whatever percentage of the market.

@twsouthwick
Copy link
Member Author

@ThomasBarnekow, this won't affect 4.5.x in any way. However, if you target 4.6, you'll get the updated System.IO.Packaging that has a few fixes that are not in the WindowsBase version of the packaging tools.

@HollyAM
Copy link

HollyAM commented Mar 21, 2017

@ThomasBarnekow,
.NET 4.6 or a greater version is present on all win10 machines, so you can count on them being on over 300 Million active devices: https://blogs.windows.com/windowsexperience/2016/05/05/windows-10-now-on-300-million-active-devices-free-upgrade-offer-to-end-soon/

They are also present on other OSes windows 7 or greater. We don't typically make those numbers public, but if you can explain your need more specifically, I might be able to provide more details.

@ThomasBarnekow
Copy link
Collaborator

@HollyAM, thanks for responding. I will contact you by email to explain what I would need to know.

@twsouthwick twsouthwick changed the title Add support for .NET 3.5, .NET 4.0, and .NET 4.6 [WIP] Add support for .NET 3.5, .NET 4.0, and .NET 4.6 Apr 14, 2017
This adds target frameworks for more .NET Framework versions, including
moving to .NET 4.6 instead of .NET 4.5. That way, .NET 4.6 and later can
use System.IO.Packaging, while frameworks below that will have access to
the library, but will use WindowsBase.
@twsouthwick twsouthwick changed the title [WIP] Add support for .NET 3.5, .NET 4.0, and .NET 4.6 Add support for .NET 3.5, .NET 4.0, and .NET 4.6 Apr 14, 2017
@twsouthwick
Copy link
Member Author

@tomjebo This is ready to review. Thanks!

@tomjebo tomjebo merged commit ac6380d into dotnet:vNext Apr 24, 2017
@tomjebo
Copy link
Collaborator

tomjebo commented Apr 24, 2017

@twsouthwick sorry I didn't get to this until now. I decided to leave the two commits separate as they seemed to be logically independent enough. Hope that's ok with you. Thanks for straightening all of this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants