Remove GetKeyedService of specified type as .NET 10 implemented it as well #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemented the same method signature.
| @@ -21,18 +21,4 @@ public static TResult CreateInstance<TResult>(this IServiceProvider provider, Ty | |||
| { | |||
| return (TResult)ActivatorUtilities.CreateInstance(provider, type); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Are we sure that the new net10 method works the same way?
There was a problem hiding this comment.
Good point, it seems to be very similar (essentially the same, checks one extra input for null): https://github.com/dotnet/runtime/blame/main/src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ServiceProviderKeyedServiceExtensions.cs#L41-L52 (runtime).
DrewScoggins
approved these changes
Nov 21, 2024
LoopedBard3
added a commit
that referenced
this pull request
Jan 14, 2025
…lemented the same method signature. (#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove GetKeyedService of specified type as .NET 10 seems to have implemented the same method signature.
The warning that was being hit was: