Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename instruments to instrumentation #3865

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Rename instruments to instrumentation #3865

merged 4 commits into from
Mar 6, 2025

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Mar 6, 2025

Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 2ca1a5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan ardatan changed the title Rename instruments Rename instruments to instrumentation Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@ardatan ardatan merged commit dee7995 into main Mar 6, 2025
24 of 25 checks passed
@ardatan ardatan deleted the rename-instruments branch March 6, 2025 15:56
Copy link
Contributor

github-actions bot commented Mar 6, 2025

💻 Website Preview

The latest changes are available as preview in: https://e8cf92c2.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Mar 6, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 515428      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 104 MB  691 kB/s
     http_req_blocked.............................: avg=1.47µs   min=972ns    med=1.3µs    max=255.89µs p(90)=1.92µs   p(95)=2.1µs   
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=148.95µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=365.18µs min=224.27µs med=334.66µs max=18.91ms  p(90)=475.41µs p(95)=497.33µs
       { expected_response:true }.................: avg=365.18µs min=224.27µs med=334.66µs max=18.91ms  p(90)=475.41µs p(95)=497.33µs
     ✓ { mode:graphql-jit }.......................: avg=291.03µs min=224.27µs med=275.63µs max=18.91ms  p(90)=304.8µs  p(95)=315.4µs 
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=500.56µs min=414.97µs med=477.84µs max=7.47ms   p(90)=519.61µs p(95)=575.24µs
     ✓ { mode:graphql-response-cache }............: avg=352.2µs  min=276.77µs med=336.1µs  max=7.1ms    p(90)=365.35µs p(95)=375.6µs 
     ✓ { mode:graphql }...........................: avg=365.29µs min=281.05µs med=339.33µs max=14.96ms  p(90)=382.53µs p(95)=428.91µs
     ✓ { mode:uws }...............................: avg=354.59µs min=274.3µs  med=336.38µs max=9.25ms   p(90)=369.12µs p(95)=387.31µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 257714
     http_req_receiving...........................: avg=32.73µs  min=16.31µs  med=32.45µs  max=3.21ms   p(90)=39.28µs  p(95)=41.67µs 
     http_req_sending.............................: avg=8.47µs   min=5.96µs   med=7.46µs   max=1.08ms   p(90)=10.92µs  p(95)=11.8µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=323.98µs min=191.79µs med=294.54µs max=18.81ms  p(90)=434.01µs p(95)=453.86µs
     http_reqs....................................: 257714  1718.072099/s
     iteration_duration...........................: avg=577.1µs  min=392.32µs med=542.49µs max=19.38ms  p(90)=690.36µs p(95)=718.27µs
     iterations...................................: 257714  1718.072099/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant