Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump whatwg-node to fix HTTP/2 stream issue #3808

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Feb 24, 2025

Fixes #3803

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 9200bc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
graphql-yoga Patch
@graphql-yoga/nestjs Patch
@graphql-yoga/render-graphiql Patch
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/apollo-managed-federation Patch
@graphql-yoga/plugin-apollo-usage-report Patch
@graphql-yoga/plugin-apq Patch
@graphql-yoga/plugin-csrf-prevention Patch
@graphql-yoga/plugin-defer-stream Patch
@graphql-yoga/plugin-disable-introspection Patch
@graphql-yoga/plugin-graphql-sse Patch
@graphql-yoga/plugin-jwt Patch
@graphql-yoga/plugin-persisted-operations Patch
@graphql-yoga/plugin-prometheus Patch
@graphql-yoga/plugin-response-cache Patch
@graphql-yoga/plugin-sofa Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan force-pushed the bump-whatwg-node-http2 branch from 85845c7 to 059d0be Compare February 24, 2025 11:06
Copy link
Contributor

github-actions bot commented Feb 24, 2025

💻 Website Preview

The latest changes are available as preview in: https://cc548730.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Feb 24, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 516130      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 104 MB  692 kB/s
     http_req_blocked.............................: avg=1.5µs    min=982ns    med=1.3µs    max=247.91µs p(90)=1.99µs   p(95)=2.17µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=145.14µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=358.81µs min=214.31µs med=327.61µs max=18.73ms  p(90)=469.02µs p(95)=490.11µs
       { expected_response:true }.................: avg=358.81µs min=214.31µs med=327.61µs max=18.73ms  p(90)=469.02µs p(95)=490.11µs
     ✓ { mode:graphql-jit }.......................: avg=286.71µs min=214.31µs med=270.85µs max=18.73ms  p(90)=301.18µs p(95)=313.41µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=494.03µs min=411.16µs med=470.89µs max=9.21ms   p(90)=509.33µs p(95)=558.63µs
     ✓ { mode:graphql-response-cache }............: avg=344.59µs min=269.09µs med=328.83µs max=6.32ms   p(90)=358.75µs p(95)=369.33µs
     ✓ { mode:graphql }...........................: avg=362.54µs min=277.51µs med=336.52µs max=13.94ms  p(90)=381.05µs p(95)=425.91µs
     ✓ { mode:uws }...............................: avg=343.27µs min=267.8µs  med=325.38µs max=6.61ms   p(90)=359.35µs p(95)=382.6µs 
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 258065
     http_req_receiving...........................: avg=32.73µs  min=15.94µs  med=32.14µs  max=2.58ms   p(90)=39.1µs   p(95)=41.68µs 
     http_req_sending.............................: avg=8.8µs    min=6.12µs   med=7.74µs   max=2.3ms    p(90)=11.16µs  p(95)=12.3µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=317.27µs min=184.31µs med=287.15µs max=18.6ms   p(90)=426.89µs p(95)=446.46µs
     http_reqs....................................: 258065  1720.417104/s
     iteration_duration...........................: avg=576.27µs min=393.4µs  med=541.6µs  max=19.3ms   p(90)=687.13µs p(95)=712.51µs
     iterations...................................: 258065  1720.417104/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@ardatan ardatan merged commit fbf328c into main Feb 24, 2025
24 checks passed
@ardatan ardatan deleted the bump-whatwg-node-http2 branch February 24, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js HTTP2 error
1 participant