Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use stable SWAPI endpoint in examples #10242

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Conversation

eddeee888
Copy link
Collaborator

Description

https://github.com/graphql/swapi-graphql recently moved to a new endpoint, so this PR updates the endpoint references.
Some tests were failing because they were using the old endpoint

Type of change

  • Fix CI

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 6dae7a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 15, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/client-preset 4.6.0-alpha-20250117130226-6dae7a681527f271cea967ed9785bd74c7aa7104 npm ↗︎ unpkg ↗︎

@eddeee888 eddeee888 changed the title Switch to use https://swapi-graphql.netlify.app/graphql Switch to use https://swapi-graphql.netlify.app/graphql in examples Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

💻 Website Preview

The latest changes are available as preview in: https://61c4006d.graphql-code-generator.pages.dev

saihaj
saihaj previously approved these changes Jan 15, 2025
Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh i would move to this is the stable endpoint. Folks try to point to the neltify thing but that's internal only (yes people find it) but this endpoint you can be certain will be there :)

https://graphql.org/graphql/

@saihaj saihaj dismissed their stale review January 15, 2025 14:53

meant to request changes

@eddeee888 eddeee888 changed the title Switch to use https://swapi-graphql.netlify.app/graphql in examples Switch to use stable SWAPI endpoint in examples Jan 16, 2025
@eddeee888
Copy link
Collaborator Author

Thanks @saihaj ! I've updated to https://graphql.org/graphql/, and we worked through the endpoint issues outside of this PR. This is now working!

I'll merge this first to unblock CI & rebase a few PRs - if there's other comments, happy to implement as subsequent PRs

@eddeee888 eddeee888 merged commit 05d9731 into master Jan 18, 2025
20 checks passed
@eddeee888 eddeee888 deleted the fix-examples-tests branch January 18, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants