Fix load schema pointer type #10227
Open
Fix load schema pointer type #10227
+96
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5558de2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
5.0.4-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
5.6.1-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.13-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.13-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.4.1-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.4.2-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.13-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.1.3-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.6.0-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.13-alpha-20250126103404-5558de2d7331f3bb08ce6e7aac9aa1678959cb8c |
npm ↗︎ unpkg ↗︎ |
ardatan
reviewed
Jan 3, 2025
| @@ -28,7 +28,7 @@ export const defaultDocumentsLoadOptions = { | |||
| }; | |||
|
|
|||
| export async function loadSchema( | |||
| schemaPointers: UnnormalizedTypeDefPointer, | |||
| schemaPointers: UnnormalizedTypeDefPointer | UnnormalizedTypeDefPointer[], | |||
There was a problem hiding this comment.
Should we add tests for this use case?
There was a problem hiding this comment.
Good idea! This is done in 9efc60b
Note that instead of testing this load.ts directly, I'm passing multiple schemas into Codegen Context which eventually passes those schemas to load.ts
💻 Website PreviewThe latest changes are available as preview in: https://e487a17f.graphql-code-generator.pages.dev |
66ea8b9 to
6ee50e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a type issue in functions used in programmatic scenarios which have the wrong type for schema param. We can take a single schema or an array. This PR adds the array part to it
Related # #10196
Type of change
How Has This Been Tested?