[client-preset] I want to add /* eslint-disable */ to fragment-masking.ts

[MH4GF]

Hello! I am a fan of graphql-code-generator! I am now trying to implement client-preset.
Of the code generated by this preset, only fragment-masking.ts is not eslint-disable. Is there any reason why you have not done so?

Also, while it seems easy enough to add, I am wondering if this change should be marked as a breaking change.

Thanks!

[saihaj]

usually you would want to avoid linting generated files. But if you are running then codegen plugin system allows you to simply add yourself without codegen being opinionated on what to disable and what not to.

You can use @graphql-codegen/add.

Duplicate: #8807

[MH4GF]

@eperez-zuora I solved this problem by adding directly to .eslintignore .
https://eslint.org/docs/latest/use/configure/ignore

[espipj]

I would say this is a bug could it be further investigated?

[Sashkan]

Any update on this ? I'm not fan of updating the .eslintignore to handle something that only affects a fragment (huhu) of the generated codebase

[hyunchulkwak]

I added this to codegen.ts to override fragment-masking config. Thanks to @MH4GF

import { preset } from '@graphql-codegen/client-preset';
import * as addPlugin from '@graphql-codegen/add';

const originalBuildGeneratesSection = preset.buildGeneratesSection;
preset.buildGeneratesSection = (...args) => {
  const result = originalBuildGeneratesSection(...args);

  if (!Array.isArray(result)) return result;

  result.forEach(({ pluginMap, plugins }) => {
    if ('fragment-masking' in pluginMap) {
      pluginMap['add'] = addPlugin;
      plugins.push({ add: { content: '/* eslint-disable */' } });
    }
  })

  return result;
};

[MH4GF]

It would be nice to solve this on the client-preset side if possible, but this is a great work-around. Thanks! @hyunchulkwak