Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: request - do not pluck data out but return full response #131

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

divyenduz
Copy link
Collaborator

@divyenduz divyenduz commented Jul 12, 2018

This enables binding.request function to:-

  1. Pass GraphQL error to binding.request function callee
  2. Support multiple top-level queries with binding.request function

Partially fixes: prisma-labs/prisma-binding#182

@divyenduz divyenduz requested a review from timsuchanek July 12, 2018 10:49
@divyenduz divyenduz changed the title BREAKING CHANGE: request - do not pluck data out but return full response fix: request - do not pluck data out but return full response Jul 16, 2018
@divyenduz divyenduz changed the title fix: request - do not pluck data out but return full response feat: request - do not pluck data out but return full response Jul 16, 2018
@divyenduz divyenduz merged commit 9fc7abc into master Jul 16, 2018
@simonjoom
Copy link

Hello i think i found same problem with this 'data' when i used subscription:
Related to:
prisma-labs/prisma-binding#229 (comment)

In Delegate
need to change [info.fieldName] = data.value[fieldName]
to [info.fieldName] = value[fieldName]

Applied this my subscriptions work with the last prisma-binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prisma.request Promise returns undefined on error
2 participants