Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gh action output for url and url_html #198

Closed
wants to merge 16 commits into from
Closed

add gh action output for url and url_html #198

wants to merge 16 commits into from

Conversation

peterwhitesell
Copy link

Changes

  • add github action output for url and url_html so they can be referenced by other actions in a workflow

@dharmendrasha dharmendrasha requested a review from dorny November 2, 2022 23:02
@dorny
Copy link
Owner

dorny commented Nov 5, 2022

@peterwhitesell Thanks for your contribution.
Could you merge the current main to your branch and solve the conflicts?
I will merge it afterward.

@peterwhitesell
Copy link
Author

@dorny merged in main and resolved conflicts in dist. thanks for the review!

dorny
dorny requested changes Nov 13, 2022
View reviewed changes
src/main.ts
Comment on lines +197 to +198
core.setOutput('url', resp.data.url)
core.setOutput('url_html', resp.data.html_url)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterwhitesell I've just noticed this is executed in a loop. Multiple check runs might be created if the input path has a pattern matching more files. In that case, the url variable would be set to the last one. What's your use case? We could leave it as is or output JSON encoded array instead. Not sure what's a better approach.

src/main.ts
@@ -211,6 +214,8 @@ class TestReporter {
return new JestJunitParser(options)
case 'mocha-json':
return new MochaJsonParser(options)
case 'go-junit':
return new GoJunitParser(options)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have go-junit support documented in the README and action.yml

@sonomirco
Copy link

Hi @dorny and @peterwhitesell
This is precisely what I am looking for!
I noticed the HTML /runs/
Could this directory be fixed? So I can link it to a GitHub Env in a GitHub action doing something like this.

environment:
  name: unit-test
  url: <report-url>

@sonomirco
Copy link

@peterwhitesell and @dorny seems this PR is not moving forward.
Do you have any updates?

@luisito666
Copy link
Contributor

I am the original developer of this feature and i decide to create another PR
Here is the PR #242

@j-catania
Copy link
Collaborator

#242 Merged.
Thanks both

@j-catania j-catania closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorny dorny dorny requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peterwhitesell @dorny @sonomirco @luisito666 @j-catania @cristidumitru