Improved listing of matching files with list-files: shell and list-files: escape options
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of
shellformat always wrapped filename with single quotes.This should normally work fine with bash but in #54 it was reported to cause some issues.
This PR changes implementation of
shelloption to not quote filename if it's not necessary and also includes alternative format using backslashes to escape characters.Options for
list-filesinput:shell: Space delimited list usable as command line argument list in Linux shell.If needed it uses single or double quotes to wrap filename with unsafe characters.
escape: Space delimited list usable as command line argument list in Linux shell.Backslash escapes every potentially unsafe character.
Closes #54