Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #120

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Document #120

wants to merge 43 commits into from

Conversation

Notify-ctrl
Copy link
Collaborator

@Notify-ctrl Notify-ctrl commented Jan 25, 2021

新神杀文档

Copy link
Owner

@donle donle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend to rename the folder to core

@Notify-ctrl Notify-ctrl reopened this Jan 31, 2021
@Notify-ctrl Notify-ctrl changed the title Doc for character(partly) Update character.md Jan 31, 2021
@Notify-ctrl Notify-ctrl requested a review from donle January 31, 2021 06:34
@Notify-ctrl Notify-ctrl changed the title Update character.md Doc:character and shared Jan 31, 2021
@Notify-ctrl
Copy link
Collaborator Author

recommend to rename the folder to core

@Notify-ctrl Notify-ctrl changed the title Doc:character and shared Document Feb 1, 2021
Copy link
Owner

@donle donle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to use underline to connect each words in the filename

doc/generate.ts Outdated
import { TranslationModule } from 'core/translations/translation_module';
import { Languages } from 'core/translations/translation_json_tool';
import { Functional } from 'core/shares/libs/functional';
import { SimplifiedChinese } from 'languages/zh_CN'; // 该问题大可忽略
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find a way to build different languages version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants