Set GPG_TTY

Fixes gopasspw#448
Fixes gopasspw#451

action/otp.go

@@ -83,6 +83,7 @@ func (s *Action) OTP(ctx context.Context, c *cli.Context) error {
 
 	if c.String("qr") != "" {
 		var qr []byte
+		var err error
 		switch otp.Type() {
 		case twofactor.OATH_HOTP:
 			hotp := otp.(*twofactor.HOTP)
@@ -92,11 +93,12 @@ func (s *Action) OTP(ctx context.Context, c *cli.Context) error {
 			qr, err = totp.QR(label)
 		default:
 			err = errors.New("QR codes can only be generated for OATH OTPs")
+		}
+		if err != nil {
 			return s.exitError(ctx, ExitIO, err, "%s", err)
 		}
 
-		err := ioutil.WriteFile(c.String("qr"), qr, 0600)
-		if err != nil {
+		if err := ioutil.WriteFile(c.String("qr"), qr, 0600); err != nil {
 			return s.exitError(ctx, ExitIO, err, "failed to write QR code: %s", err)
 		}
 	}

backend/gpg/cli/gpg.go

@@ -50,6 +50,13 @@ func New(cfg Config) *GPG {
 	// this setting should be inherited by sub-processes
 	umask(077)
 
+	// make sure GPG_TTY is set (if possible)
+	if gt := os.Getenv("GPG_TTY"); gt == "" {
+		if t := tty(); t != "" {
+			_ = os.Setenv("GPG_TTY", t)
+		}
+	}
+
 	if len(cfg.Args) < 1 {
 		cfg.Args = defaultArgs
 	}

backend/gpg/cli/utils.go

@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"os"
 	"strconv"
 	"strings"
 	"time"
@@ -42,3 +43,13 @@ func splitPacket(in string) map[string]string {
 	}
 	return m
 }
+
+// see https://www.gnupg.org/documentation/manuals/gnupg/Invoking-GPG_002dAGENT.html
+func tty() string {
+	fd0 := "/proc/self/fd/0"
+	dest, err := os.Readlink(fd0)
+	if err != nil {
+		return ""
+	}
+	return dest
+}

utils/termwiz/selection.go

@@ -28,7 +28,6 @@ func GetSelection(ctx context.Context, prompt, usage string, choices []string) (
 	}
 	defer termbox.Close()
 
-	termbox.SetInputMode(termbox.InputEsc)
 	const coldef = termbox.ColorDefault
 	termbox.Clear(coldef, coldef)