Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db.options to manifest #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add db.options to manifest #6

wants to merge 2 commits into from

Conversation

mshick
Copy link

@mshick mshick commented Sep 5, 2014

This adds the db options object to the manifest if it exists.

I was looking for a way to access these in my multilevel client and came across this ticket. juliangruber/multilevel#17

@juliangruber
Copy link
Contributor

👍

@dominictarr
Copy link
Owner

this is probably a good idea, but can you describe the specific use case where you need this?

@mshick
Copy link
Author

mshick commented Sep 6, 2014

I'm working on a hapijs/catbox cache adapter using Multilevel, catbox-multilevel. For practical reasons I'm limiting the scope of the project to use utf8 keys, and json or utf8 vals (usage is very similar to redis). I attempted to put a non-JSON-parseable string into a datastore with json value encodings which caused an error on the Multilevel server (since it ignored the local opts).

In the interest of saving people headaches, I'd like to read in the server key and value encoding options, and either set the module's mode automatically, or trigger a warning for the user attempting to start the adapter with mismatched options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants