Skip to content

Commit

Permalink
📝 Docs: Update TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
dominicstop committed Mar 27, 2023
1 parent e073411 commit e2a842e
Showing 1 changed file with 15 additions and 16 deletions.
31 changes: 15 additions & 16 deletions docs/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@
- [ ] **Subtask** - `TODO:2023-03-24-01-14-26` - Remove/Replace `UIWindow.key`.
- [ ] **Subtask** - `TODO:2023-03-20-21-29-36`  - Move `RNIModalManager` helper functions to `RNIUtilities`.
- [ ] **Subtask** - `TODO:2023-03-04-13-22-34` - **Refactor**: Remove `ViewModuleRelatedTypes`
* **Desc**: Move/Consolidate `src/types/ViewModuleRelatedTypes` to `react-native-utilities` and remove.
* **Desc**: Move/Consolidate `src/types/ViewModuleRelatedTypes` to `react-native-utilities` and remove.

<br>

- [ ] **Subtask** - `TODO:2023-03-22-12-18-37` - **Refactor**: Remove `deinitControllers`

* Refactor `RNIModalView` so that we don't have to constantly cleanup.

<br>

Expand Down Expand Up @@ -54,7 +60,9 @@
<br>

- [ ] `TODO:2023-03-04-13-15-11` - **Refactor**: Use Will/Did Prefix for `RNIModalView` Events

* **Desc**: Refactor `RNIModalView` events to use "will/did" prefix, and deprecate old event names (for backwards compatibility).

* Remove `RNIModalView.onModalDismiss`
* Remove `RNIModalView.onModalShow`
* Rename `RNIModalView.onModalAttemptDismiss` to `RNIModalView.onModalDidAttemptToDismiss`
Expand All @@ -77,6 +85,10 @@
* Add invocation for deprecated event `ModalView.onModalFocus`
* Update examples.

<br>

* [ ] **Subtask** - `TODO:2023-03-04-13-06-27` - **Impl**: Update `RNIModalView` Native Events

<br>

- [ ] `TODO:2023-03-04-06-34-28` - Library Native Cleanup
Expand Down Expand Up @@ -105,11 +117,6 @@

<br>

* [ ] **Subtask** - `TODO:2023-03-22-12-18-37` - **Refactor**: Remove `deinitControllers`
* Refactor `RNIModalView` so that we don't have to constantly cleanup.

<br>

* [x] **Subtask** - `TODO:2023-03-22-12-09-34` - Move to `get` property called `synthesizedNativeEventBase`
* **Desc**: Refactor `createModalNativeEventDict`.

Expand All @@ -128,7 +135,7 @@

<br>

* [ ] **Subtask** - `TODO:2023-03-04-15-39-46` - **Impl**: `RNIModalManager`
* [x] **Subtask** - `TODO:2023-03-04-15-39-46` - **Impl**: `RNIModalManager`
* **Desc**: Implement `RNIModalManager` singleton for handling modal focus/blur logic.
* Modal focus/blur re-write.
* Consolidate focus/blur related logic to this class, This class will be notified whenever a new modal is presented or dismissed.
Expand All @@ -154,10 +161,7 @@

<br>

- [ ] **Subtask** - `TODO:2023-03-05-00-33-15` - **Refactor**: Re-write `dismissModalByID`
* **Desc**: Cleanup + Re-write `RNIModalViewModule.dismissModalByID`.

<br>
- [ ] **Subtask** - `TODO:2023-03-05-00-33-15` - **Refactor**: Remove `RNIModalViewModule.dismissModalByID`.

- [x] **Subtask** - `TODO:2023-03-04-15-38-02` - **Refactor**: Remove `RNIModalViewManager.currentModalLevel`.

Expand All @@ -167,11 +171,6 @@

<br>

- [ ] **Subtask** - `TODO:2023-03-04-13-06-27` - **Impl**: Update `RNIModalView` Native Events
* **Desc**: Update `RNIModalView` native event parameters (i.e. send over more relevant data).

<br>

- <u>Related</u>:
* `TODO:2023-03-04-05-25-44` - Library Cleanup
* `Note:2023-03-04-02-58-31`
Expand Down

0 comments on commit e2a842e

Please sign in to comment.