Skip to content

Commit

Permalink
📝 Docs: Update TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
dominicstop committed Mar 21, 2023
1 parent 0e8a154 commit b404fcd
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions docs/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@

<br>

* [ ] **Subtask** - `TODO:2023-03-17-12-42-02` - Remove `RNIModalView.modalUUID`
* [x] **Subtask** - `TODO:2023-03-16-15-16-09` - Remove `RNIModalView.DefaultValues`
* [x] **Subtask** - `TODO:2023-03-16-15-19-13` - Remove `RCTSwiftLog`

Expand All @@ -61,34 +62,34 @@
* Consolidate focus/blur related logic to this class, This class will be notified whenever a new modal is presented or dismissed.
* It will then be responsible to notify/"hand out" blur/focus events to other modals.
* Will be responsible for keeping track how many modals are currently active, etc.

<br>

- [ ] **Subtask** - `TODO:2023-03-05-00-32-43` - **Fix**: Edge Case - Modal Focus/Blur Bug
* **Desc**: Add code to manually propagate modal blur/focus events.
* The modal is being dismissed via calling the modal view controller's dismiss method. As such, the focus/blur event is not being propagated.

<br>

- [ ] **Subtask** - `TODO:2023-03-05-00-33-15` - **Refactor**: Re-write `dismissModalByID`
* **Desc**: Cleanup + Re-write `RNIModalViewModule.dismissModalByID`.

<br>

- [ ] **Subtask** - `TODO:2023-03-04-15-38-02` - **Refactor**: Relocate `currentModalLevel`
- **Desc**: Relocate `RNIModalViewManager.currentModalLevel` property to a singleton called `RNIModalManager`.

<br>

- [ ] **Subtask** - `TODO:2023-03-04-15-33-15` - **Refactor**: Relocate `delegatesFocus`
* **Desc**: Relocate `RNIModalViewManager.delegatesFocus` property to a singleton called `RNIModalManager`.

<br>

- [ ] **Subtask** - `TODO:2023-03-04-15-49-02` - **Refactor**: Relocate `presentedModalRefs`

<br>

- [ ] **Subtask** - `TODO:2023-03-04-13-06-27` - **Impl**: Update `RNIModalView` Native Events
* **Desc**: Update `RNIModalView` native event parameters (i.e. send over more relevant data).
* Add param `isUserInitiated` to indicate if an event was fired due to a user action.
Expand Down

0 comments on commit b404fcd

Please sign in to comment.