🛠 Refactor: Rename ModalView.state.visible

Summary: Rename `ModalView.state.visible` to `shouldMountModalContent`.
dominicstop · Jan 9, 2023 · 55e72b4 · 55e72b4
1 parent 7f0ab6d
commit 55e72b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/ModalView/ModalView.tsx b/src/components/ModalView/ModalView.tsx
@@ -60,7 +60,7 @@ export class ModalView extends
     this.emitter = new TSEventEmitter();
 
     this.state = {
-      visible: false,
+      shouldMountModalContent: false,
       childProps: null,
       enableSwipeGesture: props.enableSwipeGesture,
       isModalInPresentation: props.isModalInPresentation,
@@ -69,7 +69,7 @@ export class ModalView extends
 
   componentWillUnmount() {
     const { autoCloseOnUnmount } = this.getProps();
-    const { visible } = this.state;
+    const { shouldMountModalContent: visible } = this.state;
 
     if (autoCloseOnUnmount && visible) {
       this.setVisibility(false);
@@ -170,7 +170,7 @@ export class ModalView extends
   };
 
   setVisibility = async (nextVisible, childProps = null) => {
-    const { visible: prevVisible } = this.state;
+    const { shouldMountModalContent: prevVisible } = this.state;
 
     const didChange = (prevVisible !== nextVisible);
 
@@ -299,7 +299,7 @@ export class ModalView extends
     );
 
     this.setState({
-      visible: false,
+      shouldMountModalContent: false,
       childProps: null,
       // reset state values from props
       enableSwipeGesture: props.enableSwipeGesture,
@@ -366,7 +366,7 @@ export class ModalView extends
         {...overrideProps}
         {...props.viewProps}
       >
-        {state.visible && (
+        {state.shouldMountModalContent && (
           <View
             style={[styles.modalContentContainer, props.containerStyle]}
             collapsable={false}

diff --git a/src/components/ModalView/ModalViewTypes.ts b/src/components/ModalView/ModalViewTypes.ts
@@ -43,7 +43,7 @@ export type ModalViewProps =
   ViewProps & ModalViewBaseProps;
 
 export type ModalViewState = {
-  visible: boolean;
+  shouldMountModalContent: boolean;
   childProps: unknown;
   enableSwipeGesture: boolean;
   isModalInPresentation: boolean;