Skip to content

Commit

Permalink
📝 Docs: Update TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
dominicstop committed Mar 22, 2023
1 parent 27f5965 commit 537f49d
Showing 1 changed file with 19 additions and 6 deletions.
25 changes: 19 additions & 6 deletions docs/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,30 +58,43 @@

<br>

* [ ] **Subtask** - `TODO:2023-03-22-12-18-37` - Refactor: Remove `deinitControllers`
* Refactor `RNIModalView` so that we don't have to constantly cleanup...
* [ ] **Subtask** - `TODO:2023-03-22-12-33-26` - **Refactor**: Remove `modalNVC`
* Remove `RNIModalView.modalNVC` + usage.

<br>

* [ ] **Subtask** - `TODO:2023-03-22-12-18-37` - **Refactor**: Remove `deinitControllers`
* Refactor `RNIModalView` so that we don't have to constantly cleanup.

<br>

* [ ] **Subtask** - `TODO:2023-03-22-12-09-34` - Move to `get` property called `synthesizedNativeEventBase`
* **Desc**: Refactor `createModalNativeEventDict`.

<br>

* [ ] **Subtask** - `TODO:2023-03-22-12-07-54` - **Refactor**: Move to `RNIModalManager`
* **Desc**: Move `RNIModalView.setIsHiddenForViewBelowLevel` to `RNIModalManager`.

<br>

* [ ] **Subtask** - `TODO:2023-03-22-11-33-06` - Add `synthesized-` prefix to properties.
* [x] **Subtask** - `TODO:2023-03-17-15-32-16` - Rename to `RNIModalView.isModalInFocus`
* [ ] **Subtask** - `TODO:2023-03-17-12-42-02` - Remove `RNIModalView.modalUUID`
* [x] **Subtask** - `TODO:2023-03-16-15-16-09` - Remove `RNIModalView.DefaultValues`
* [x] **Subtask** - `TODO:2023-03-16-15-19-13` - Remove `RCTSwiftLog`

<br>

<br>

* [ ] **Subtask** - `TODO:2023-03-04-15-39-46` - **Impl**: `RNIModalManager`
* **Desc**: Implement `RNIModalManager` singleton for handling modal focus/blur logic.
* Modal focus/blur re-write.
* Consolidate focus/blur related logic to this class, This class will be notified whenever a new modal is presented or dismissed.
* It will then be responsible to notify/"hand out" blur/focus events to other modals.
* Will be responsible for keeping track how many modals are currently active, etc.

<br>

- [ ] **Subtask** - `TODO:2023-03-05-00-32-43` - **Fix**: Edge Case - Modal Focus/Blur Bug
* **Desc**: Add code to manually propagate modal blur/focus events.
* The modal is being dismissed via calling the modal view controller's dismiss method. As such, the focus/blur event is not being propagated.
Expand Down

0 comments on commit 537f49d

Please sign in to comment.