🛁 Cleanup: RNIModalSheetViewDelegate

dominicstop · Sep 27, 2024 · 427af51 · 427af51
1 parent e533692
commit 427af51
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/ios/RNIModalSheetView/RNIModalSheetViewDelegate.swift b/ios/RNIModalSheetView/RNIModalSheetViewDelegate.swift
@@ -25,9 +25,9 @@ public final class RNIModalSheetViewDelegate: UIView, RNIContentView {
     case onModalDidHide;
   };
 
-  public enum Events: String, CaseIterable {
-    case placeholderEvent;
-  }
+  public static var propKeyPathMap: PropKeyPathMap {
+    return [:];
+  };
 
   // MARK: Properties
   // ----------------
@@ -120,21 +120,9 @@ extension RNIModalSheetViewDelegate: RNIContentViewDelegate {
     index: NSInteger,
     superBlock: () -> Void
   ) {
-    // no-op
+    childComponentView.removeFromSuperview();
   }
 
-  public func notifyDidSetProps(sender: RNIContentViewParentDelegate) {
-    // no-op
-  };
-
-  public func notifyOnUpdateLayoutMetrics(
-    sender: RNIContentViewParentDelegate,
-    oldLayoutMetrics: RNILayoutMetrics,
-    newLayoutMetrics: RNILayoutMetrics
-  ) {
-    // no-op
-  };
-
   public func notifyOnViewCommandRequest(
     sender: RNIContentViewParentDelegate,
     forCommandName commandName: String,

diff --git a/src/components/ModalSheetView/ModalSheetView.tsx b/src/components/ModalSheetView/ModalSheetView.tsx
@@ -36,7 +36,6 @@ export const ModalSheetView = React.forwardRef<
     setModalSheetContentMap
   ] = React.useState<ModalSheetContentMap>({});
 
-
   const isModalContentLazy = props.isModalContentLazy ?? true;
 
   const shouldMountModalContents = 
@@ -91,8 +90,6 @@ export const ModalSheetView = React.forwardRef<
   const shouldEnableDebugBackgroundColors = 
     props.shouldEnableDebugBackgroundColors ?? false;
 
-
-
   const children = React.Children.map(props.children, (child) => {
     return React.cloneElement(
       child as React.ReactElement<ModalSheetViewContentProps>, 
@@ -105,6 +102,7 @@ export const ModalSheetView = React.forwardRef<
 
   return (
     <RNIModalSheetView
+      {...props}
       ref={ref => nativeRef.current = ref}
       style={styles.nativeModalSheet}
     >