⭐️ Impl: ModalSheetView Dismiss Events

dominicstop · Sep 30, 2024 · 3918772 · 3918772
1 parent 1f2ac6d
commit 3918772
Show file tree

Hide file tree

Showing 8 changed files with 56 additions and 2 deletions.
diff --git a/ios/RNIModalSheetView/RNIModalSheetViewDelegate.swift b/ios/RNIModalSheetView/RNIModalSheetViewDelegate.swift
@@ -21,6 +21,9 @@ public final class RNIModalSheetViewDelegate: UIView, RNIContentView {
     case onModalWillPresent;
     case onModalDidPresent;
 
+    case onModalWillDismiss;
+    case onModalDidDismiss;
+
     case onModalWillShow;
     case onModalDidShow;
 
@@ -304,6 +307,30 @@ extension RNIModalSheetViewDelegate: ModalViewControllerEventsNotifiable {
       ]
     );
   };
+
+  public func notifyOnModalWillDismiss(
+    sender: UIViewController,
+    isAnimated: Bool
+  ) {
+    self.dispatchEvent(
+      for: .onModalWillDismiss,
+      withPayload: [
+        "isAnimated": isAnimated,
+      ]
+    );
+  };
+
+  public func notifyOnModalDidDismiss(
+    sender: UIViewController,
+    isAnimated: Bool
+  ) {
+    self.dispatchEvent(
+      for: .onModalDidDismiss,
+      withPayload: [
+        "isAnimated": isAnimated,
+      ]
+    );
+  };
 };
 
 // MARK: - RNIModalSheetViewDelegate+ViewControllerLifecycleNotifiable

diff --git a/ios/RNIModalSheetView/RNIModalSheetViewManager.mm b/ios/RNIModalSheetView/RNIModalSheetViewManager.mm
@@ -31,6 +31,9 @@ - (UIView *)view
 RNI_EXPORT_VIEW_EVENT(onModalWillPresent, RCTBubblingEventBlock);
 RNI_EXPORT_VIEW_EVENT(onModalDidPresent, RCTBubblingEventBlock);
 
+RNI_EXPORT_VIEW_EVENT(onModalWillDismiss, RCTBubblingEventBlock);
+RNI_EXPORT_VIEW_EVENT(onModalDidDismiss, RCTBubblingEventBlock);
+
 RNI_EXPORT_VIEW_EVENT(onModalWillShow, RCTBubblingEventBlock);
 RNI_EXPORT_VIEW_EVENT(onModalDidShow, RCTBubblingEventBlock);
 

diff --git a/src/components/ModalSheetView/ModalSheetView.tsx b/src/components/ModalSheetView/ModalSheetView.tsx
@@ -141,7 +141,7 @@ export const ModalSheetView = React.forwardRef<
         {...props}
         ref={ref => nativeRef.current = ref}
         style={styles.nativeModalSheet}
-        onModalDidHide={(event) => {
+        onModalDidDismiss={(event) => {
           setShouldExplicitlyMountModalContents(false);
 
           props.onModalDidHide?.(event);

diff --git a/src/components/ModalSheetView/ModalSheetViewTypes.tsx b/src/components/ModalSheetView/ModalSheetViewTypes.tsx
@@ -40,6 +40,8 @@ export type ModalSheetViewInheritedProps = Pick<RNIModalSheetViewProps,
   // common modal presentation events
   | 'onModalWillPresent'
   | 'onModalDidPresent'
+  | 'onModalWillDismiss'
+  | 'onModalDidDismiss'
   | 'onModalWillShow'
   | 'onModalDidShow'
   | 'onModalWillHide'

diff --git a/src/native_components/RNIModalSheetVIew/RNIModalSheetNativeView.ts b/src/native_components/RNIModalSheetVIew/RNIModalSheetNativeView.ts
@@ -7,7 +7,7 @@ import {
 } from './RNIModalSheetViewNativeComponent';
 
 import type { OnModalSheetStateDidChangeEvent, OnModalSheetStateWillChangeEvent } from './RNIModalSheetViewEvents';
-import type { OnModalWillPresentEvent, OnModalDidPresentEvent, OnModalWillShowEvent, OnModalDidShowEvent, OnModalWillHideEvent, OnModalDidHideEvent } from '../../types/CommonModalEvents';
+import type { OnModalWillPresentEvent, OnModalDidPresentEvent, OnModalWillShowEvent, OnModalDidShowEvent, OnModalWillHideEvent, OnModalDidHideEvent, OnModalWillDismissEvent, OnModalDidDismissEvent } from '../../types/CommonModalEvents';
 
 
 type RNIModalSheetViewNativeComponentBaseProps = 
@@ -19,6 +19,9 @@ export type RNIModalSheetNativeViewBaseProps = RemapObject<RNIModalSheetViewNati
   onModalWillPresent: OnModalWillPresentEvent;
   onModalDidPresent: OnModalDidPresentEvent;
 
+  onModalWillDismiss: OnModalWillDismissEvent;
+  onModalDidDismiss: OnModalDidDismissEvent;
+
   onModalWillShow: OnModalWillShowEvent;
   onModalDidShow: OnModalDidShowEvent;
 

diff --git a/src/native_components/RNIModalSheetVIew/RNIModalSheetViewNativeComponent.ts b/src/native_components/RNIModalSheetVIew/RNIModalSheetViewNativeComponent.ts
@@ -11,6 +11,9 @@ export interface NativeProps extends ViewProps {
   onModalWillPresent?: BubblingEventHandler<{}>;
   onModalDidPresent?: BubblingEventHandler<{}>;
 
+  onModalWillDismiss: BubblingEventHandler<{}>;
+  onModalDidDismiss: BubblingEventHandler<{}>;
+
   onModalWillShow?: BubblingEventHandler<{}>;
   onModalDidShow?: BubblingEventHandler<{}>;
   onModalWillHide?: BubblingEventHandler<{}>;

diff --git a/src/native_components/RNIModalSheetVIew/RNIModalSheetViewTypes.ts b/src/native_components/RNIModalSheetVIew/RNIModalSheetViewTypes.ts
@@ -35,6 +35,8 @@ export type RNIModalSheetViewInheritedOptionalProps = Partial<Pick<RNIModalSheet
   // common modal presentation events
   | 'onModalWillPresent'
   | 'onModalDidPresent'
+  | 'onModalWillDismiss'
+  | 'onModalDidDismiss'
   | 'onModalWillShow'
   | 'onModalDidShow'
   | 'onModalWillHide'

diff --git a/src/types/CommonModalEvents.ts b/src/types/CommonModalEvents.ts
@@ -12,6 +12,14 @@ export type OnModalDidPresentEventPayload = Readonly<{
   isAnimated: boolean;
 }>;
 
+export type OnModalWillDismissEventPayload = Readonly<{
+  isAnimated: boolean;
+}>;
+
+export type OnModalDidDidDismissEventPayload = Readonly<{
+  isAnimated: boolean;
+}>;
+
 export type OnModalWillShowEventPayload = Readonly<{
   isAnimated: boolean;
   isFirstAppearance: boolean;
@@ -39,6 +47,12 @@ export type OnModalWillPresentEvent =
 export type OnModalDidPresentEvent = 
   BubblingEventHandler<OnModalDidPresentEventPayload>;
 
+export type OnModalWillDismissEvent = 
+  BubblingEventHandler<OnModalWillDismissEventPayload>;
+
+export type OnModalDidDismissEvent = 
+  BubblingEventHandler<OnModalDidDidDismissEventPayload>;
+
 export type OnModalWillShowEvent = 
   BubblingEventHandler<OnModalWillShowEventPayload>;