Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated visuals. Corrected some of the guide. #145

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

bhozar
Copy link
Contributor

@bhozar bhozar commented Feb 11, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   65.42%   65.42%           
=======================================
  Files           3        3           
  Lines        1018     1018           
=======================================
  Hits          666      666           
  Misses        352      352

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97db183...7cfa8c2. Read the comment docs.

@seanthegeek
Copy link
Contributor

Thanks. I don't see any changes to the documentation/guide though.

@bhozar
Copy link
Contributor Author

bhozar commented Feb 12, 2020

Thanks. I don't see any changes to the documentation/guide though.

It's very minor changes as I took the line out mentioning the forensics bit was a separate dashboard, and removed the section saying about filtering using the pie charts, as it is not possible to filter in Grafana from the pie charts. Not easy to see as the file has the change as one long line.

@seanthegeek seanthegeek merged commit 0ae15ed into domainaware:master Feb 12, 2020
@seanthegeek
Copy link
Contributor

Gotcha. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants