Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when there are unknown fields in forensic report #148

Closed
davidwestlund opened this issue Feb 26, 2020 · 0 comments
Closed

Bug when there are unknown fields in forensic report #148

davidwestlund opened this issue Feb 26, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@davidwestlund
Copy link

davidwestlund commented Feb 26, 2020

Thank you for a great program.

If there are unknown fields in a forensic report, the program crashes. This can happen in the function "parsed_forensic_reports_to_csv" if the call to "parsed_forensic_reports_to_csv_rows" returns rows with fields that are not defined in the "fields" variable. One solution is to copy the known fields to a new structure (this begins at row 732 in init.py):

    for row in rows:
        new_row = {}
        for key in new_row.keys():
            new_row[key] = row[key]
        csv_writer.writerow(new_row)
seanthegeek pushed a commit that referenced this issue May 10, 2020
- Ignore unknown forensic report fields when generating CSVs (Closes issue #148)
- Fix crash on IMAP timeout (PR #164 - closes issue #163)
- Use SMTP port from the config file when sending emails (PR #151)
- Add support for Elasticsearch 7.0 (PR #161 - closes issue #149)
- Remove temporary workaround for DMARC aggregate report records missing a SPF domain fields
@seanthegeek seanthegeek self-assigned this Jun 10, 2020
@seanthegeek seanthegeek added the bug Something isn't working label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants