Add max connections and password capabilities. (#151)

This pr adds max-connections as well as the ability to connect w/ a password
dolthub · Apr 23, 2021 · 7b31d88 · 7b31d88
1 parent d34516f
commit 7b31d88
Show file tree

Hide file tree

Showing 2 changed files with 128 additions and 114 deletions.
diff --git a/doltpy/sql/sql.py b/doltpy/sql/sql.py
@@ -42,6 +42,7 @@ class ServerConfig:
     loglevel: Optional[str] = None
     multi_db_dir: Optional[str] = None
     no_auto_commit: Optional[bool] = None
+    max_connections: Optional[int] = None
     echo: bool = False
 
 
@@ -60,14 +61,21 @@ def _get_engine(self) -> Engine:
         user = self.server_config.user
         host = self.server_config.host
         port = self.server_config.port
+        password = self.server_config.password
 
         logger.info(f"Creating engine for Dolt SQL Server instance running on {host}:{port}")
 
         def inner():
-            return create_engine(
-                f"mysql+mysqlconnector://{user}@{host}:{port}/{database}",
-                echo=self.server_config.echo,
-            )
+            if password is not None:
+                return create_engine(
+                    f"mysql+mysqlconnector://{user}:{password}@{host}:{port}/{database}",
+                    echo=self.server_config.echo,
+                )
+            else:
+                return create_engine(
+                    f"mysql+mysqlconnector://{user}@{host}:{port}/{database}",
+                    echo=self.server_config.echo,
+                )
 
         return inner()
 
@@ -429,6 +437,8 @@ def inner(server_args):
                 args.extend(["--multi-db-dir", self.server_config.multi_db_dir])
             if self.server_config.no_auto_commit:
                 args.extend(["--no-auto-commit"])
+            if self.server_config.max_connections:
+                args.extend(["--max-connections", str(self.server_config.max_connections)])
 
         inner(args)