Allow ~ and fix for schema_export #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SamORichards
commented
Dec 19, 2023
•
- Allows ~ in the path when creating a new Dolt object
- Fixes a schema_export, the cli seems to have removed the need to for --filename flag
User home in path
the --filename flag appears to have been removed from the cli
max-hoffman
reviewed
Jan 5, 2024
| @@ -267,6 +267,8 @@ class Dolt(DoltT): | |||
| """ | |||
|
|
|||
| def __init__(self, repo_dir: str, print_output: Optional[bool] = None): | |||
| # allow ~ to be used in paths | |||
| repo_dir = os.path.expanduser(repo_dir) | |||
There was a problem hiding this comment.
would you mind adding a test for sample usage in tests/test_dolt.py?
max-hoffman
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.