Fixes for dolt on arm devices #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution :). Seems like a case of an improperly aligned struct field, as per golang/go#36606. I will follow up with some colleagues about landing this. |
|
We would prefer if ReaderWithStats maintained support for reading > 4GB files. So I think I have proposed a fix here: abmyii#1 |
Thank you very much! I'll test it tomorrow and ensure it doesn't just break it again. |
go/libraries/utils/iohelp: ReaderWithStats: Support > 4GB read stats.
|
@reltuk Thanks for merging! Would it be possible to get arm builds as part of the Releases rather than having to compile them myself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2229. However, I'm not confident about this PR since I have no idea of the implications of the changes, nor am I sure how to test them.
Note that I have added more fixes than just for #2229, as I discovered that
dolt table importdidn't work either.