refactoring, fix space in plugins list, add update message #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Klap-in
commented
Jan 15, 2024
•
- add a space behind list items to separate the names of the plugins with same author
- cleanup of compatibility versions
- add update message field
fiwswe
reviewed
Jan 15, 2024
|
It is old code which I was just clean up a bit... there is already a refactoring of other pieces coming. |
|
For a quick fix this should work. But my point was to use CSS for formatting and HTML for supplying the content. Using a space in HTML for formatting goes against that concept. |
use more strict typing of parameters
See dokuwiki#144 Truncate too long values to prevent mysql is not saving an entry, also it shows already in the entry the truncated lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.