-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(katana-rpc): add ContractErrorData when it applies #1297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more idiomatic to make the ContractError
variant as a struct.
Removing the Copy
trait should be fine.
That's a nice option, I've made a new proposition. The only point is that, we can't cast into I've also tried to introduce a new type WDYT? |
Add the actual data for the
ContractError
(40) which is the only one in the specification of have such inner error object.When we will be compatible with 0.6.0,
TransactionExecutionError
will also have one.@kariy I don't know if it's the most elegant way to do so. But introducing the object into the
ContractError
variant break theCopy
trait.