Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for exhausted range #4943

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

fmarco76
Copy link
Member

The exception message was reporting wrong numbers for requests because there was a non correct hex conversion. Additionally, it was reporting the wrong value because it was increasing even no new requests could be generated.

Fix BZ#2332610

The exception message was reporting wrong numbers for requests because
there was a non correct hex conversion. Additionally, it was reporting the
wrong value because it was increasing even no new requests could be
generated.

Fix BZ#2332610
@fmarco76 fmarco76 requested a review from edewata January 28, 2025 17:12
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit 080cc97 into dogtagpki:master Jan 29, 2025
161 of 172 checks passed
@fmarco76 fmarco76 deleted the ssnv2Message branch January 29, 2025 09:06
@edewata
Copy link
Contributor

edewata commented Jan 29, 2025

@fmarco76
Copy link
Member Author

Looks like it's causing these failures:
https://github.com/dogtagpki/pki/actions/runs/13027834330/job/36340673198
https://github.com/dogtagpki/pki/actions/runs/13027834330/job/36340673502

Yes, I totally miss them. I have fixed with the commit: 917a4c4

Thanks!

@edewata
Copy link
Contributor

edewata commented Jan 30, 2025

Thanks!

@edewata
Copy link
Contributor

edewata commented Jan 30, 2025

Sorry, looks like there's a couple more:
https://github.com/dogtagpki/pki/actions/runs/13049835510/job/36407803318
https://github.com/dogtagpki/pki/actions/runs/13049835510/job/36407804227

@fmarco76
Copy link
Member Author

Sorry, looks like there's a couple more: https://github.com/dogtagpki/pki/actions/runs/13049835510/job/36407803318 https://github.com/dogtagpki/pki/actions/runs/13049835510/job/36407804227

I have added a new commit and this time wait for all CIs. There are no other issue related with this. Thanks!

@edewata
Copy link
Contributor

edewata commented Jan 31, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants