Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Cert.sortCertificateChain() #133

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Added Cert.sortCertificateChain() #133

merged 1 commit into from
Mar 1, 2019

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Mar 1, 2019

The sortCertificateChain() has been moved from
com.netscape.cmsutil.crypto.CryptoUtil in PKI to
org.mozilla.jss.netscape.security.util.Cert in
JSS for reusability.

The version number has been updated to 4.5.3 such
that the JSS dependency can be set properly in
other packages.

@edewata edewata requested a review from cipherboy March 1, 2019 16:21
cipherboy
cipherboy reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thought, else feel free to push. I'd like to see tests for this, but I realize PKI doesn't have have them either.

@cipherboy cipherboy added the enhancement New feature or request label Mar 1, 2019
@cipherboy cipherboy added this to the 4.5.3 milestone Mar 1, 2019
@edewata
Added Cert.sortCertificateChain()
40d4755 
The sortCertificateChain() has been moved from
com.netscape.cmsutil.crypto.CryptoUtil in PKI to
org.mozilla.jss.netscape.security.util.Cert in
JSS for reusability.

The version number has been updated to 4.5.3 such
that the JSS dependency can be set properly in
other packages.
@edewata
Copy link
Contributor Author

edewata commented Mar 1, 2019

I'll add the unit test in a separate patch (need to generate some test certs).

@edewata edewata merged commit 91870d5 into dogtagpki:master Mar 1, 2019
@edewata edewata deleted the fips branch March 1, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

Assignees

@edewata edewata

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@edewata @cipherboy