Change API docs to allow custom URL's #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this idea! Although I am not sure why but the buttons for public API and localhost API don't appear to be working on my side. Tried on Firefox and Chrome on MacOS and on Firefox with Ubuntu. |
|
Oh, that is strange indeed. It seemed to be working locally, but they are not working on the deployed version for me either. |
|
I have not done anything and it seems to work now somehow? @mikaelGusse can you try again? I fear there is something weird going on with the caching. |
|
Oh, it seems to be broken when you directly load or refresh the page. Looks to be an issue with the eventlistener not being initialized. |
|
The issue should be fixed now and I have added persistence as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an input field to the API documentation which allows someone to change the endpoint URLs shown.
This change is already live and can be viewed on https://dolos.ugent.be/docs/api.html