Fix purged reports loading indefinitely #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5799ff4 to
2b64d1b
Compare
2b64d1b to
a8ac0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reports would be purged by the server (without the front-end knowing) it would cause the front end to keep fetching the reports indefinitely. This PR aims to fix that issue.
This is caused by the the Rails API trying to create an URL for non-existing files, throwing an error and returning an internal server error. The front-end then never gets to update the report status, causing it to keep periodically fetching the report.
This PR also removes migration code for the old local storage key.