Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some mock classes #9715

Merged
merged 1 commit into from
May 1, 2022
Merged

Remove some mock classes #9715

merged 1 commit into from
May 1, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented May 1, 2022 •
edited
Loading

  1. Use PHPUnit to generate mock results in unit tests.
  2. Move ArrayResultFactory from Doctrine\Tests\Mocks to Doctrine\Performance.
  3. Use a real connection and the SQLite driver to generate mock results for PHPBench.
  4. Remove the DriverConnectionMock, DriverMock and StatementMock classes.

@morozov morozov marked this pull request as ready for review May 1, 2022 21:11
@morozov morozov requested review from derrabus and greg0ire May 1, 2022 21:11
derrabus
derrabus approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@derrabus derrabus added this to the 3.0.0 milestone May 1, 2022
@derrabus derrabus enabled auto-merge (squash) May 1, 2022 21:22
@derrabus derrabus merged commit 11049b4 into doctrine:3.0.x May 1, 2022
@morozov morozov deleted the remove-mock-classes branch May 1, 2022 21:59
@mpdude mpdude mentioned this pull request Jan 17, 2023
Merged
@mpdude mpdude mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @derrabus