-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Proxy
marker interface
#9502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is lib/Doctrine/ORM/Proxy/Autoloader.php worth mentioning in the UPGRADE.md?
I'd like to have another reviewer who might know more about the ProxyManager topic.
e1649bf
to
beebc6d
Compare
I am not sure its a good idea to switch to proxy manager at this point, since it often takes way past release dates until its fully supported. We managed to support new php versions instantly with Proxy generator. Removing the interface is tricky, because there is no good way to raise a deprecation if code outside doctrine instanceofs the orm interface. |
True. Shall we revert the corresponding deprecations then?
That outside code would need to work with a static analysis tool. We cannot emit a runtime deprecation, that's true. What would be the way forward? Undo the deprecation and keep this interface? |
A runtime deprecation in the file would kick in as soon as a proxy is instantiated I think, so yeah, it does not look like a good option. Let's revert the deprecation I suppose. |
Closing in favor of #9532 |
Apparently, there are plans to switch to ProxyManager. I'm not sure if someone is actively working on that. Anyway, we can already remove the
Proxy
interface.