Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Proxy marker interface #9502

Closed
wants to merge 1 commit into from

Conversation

derrabus
Copy link
Member

Apparently, there are plans to switch to ProxyManager. I'm not sure if someone is actively working on that. Anyway, we can already remove the Proxy interface.

@derrabus derrabus added this to the 3.0.0 milestone Feb 10, 2022
SenseException
SenseException previously approved these changes Feb 10, 2022
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is lib/Doctrine/ORM/Proxy/Autoloader.php worth mentioning in the UPGRADE.md?

I'd like to have another reviewer who might know more about the ProxyManager topic.

@beberlei
Copy link
Member

I am not sure its a good idea to switch to proxy manager at this point, since it often takes way past release dates until its fully supported. We managed to support new php versions instantly with Proxy generator.

Removing the interface is tricky, because there is no good way to raise a deprecation if code outside doctrine instanceofs the orm interface.

@derrabus
Copy link
Member Author

I am not sure its a good idea to switch to proxy manager at this point, since it often takes way past release dates until its fully supported. We managed to support new php versions instantly with Proxy generator.

True. Shall we revert the corresponding deprecations then?

Removing the interface is tricky, because there is no good way to raise a deprecation if code outside doctrine instanceofs the orm interface.

That outside code would need to work with a static analysis tool. We cannot emit a runtime deprecation, that's true.

What would be the way forward? Undo the deprecation and keep this interface?

@beberlei
Copy link
Member

@derrabus I think its prudent to remove the deprecation. @greg0ire What do you think?

@greg0ire
Copy link
Member

A runtime deprecation in the file would kick in as soon as a proxy is instantiated I think, so yeah, it does not look like a good option. Let's revert the deprecation I suppose.

@derrabus
Copy link
Member Author

#9532

@derrabus
Copy link
Member Author

Closing in favor of #9532

@derrabus derrabus closed this Feb 25, 2022
@derrabus derrabus deleted the remove/proxy-interface branch February 25, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants