Add native types to CacheLogger implementations #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
931a4b6 to
beaa526
Compare
greg0ire
reviewed
Jan 19, 2022
| @@ -19,69 +19,69 @@ interface CacheLogger | |||
| * @param string $regionName The name of the cache region. | |||
| * @param EntityCacheKey $key The cache key of the entity. | |||
There was a problem hiding this comment.
This phpdoc is now quite tautological isn't it? Let's reconsider the comments?
There was a problem hiding this comment.
I've removed the descriptions.
beaa526 to
52bb959
Compare
greg0ire
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.