Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update working-with-objects.rst #7553

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Update working-with-objects.rst #7553

merged 1 commit into from
Jan 1, 2025

Conversation

CraicOverflow89
Copy link
Contributor

Spelling.

greg0ire
greg0ire previously approved these changes Jan 4, 2019
View reviewed changes
Majkl578
Majkl578 suggested changes Jan 6, 2019
View reviewed changes
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is good but I'm going to be annoying and ask for a better commit message, at least i.e. "Fix typo in Working with Objects chapter".

@greg0ire
Copy link
Member

greg0ire commented Jan 6, 2019

@CraicOverflow89 I see this is your first contribution so here is some help:

cd /tmp
git clone git@github.com:CraicOverflow89/orm.git
cd orm
git checkout patch-1
git commit --amend
git push --force

@github-actions GitHub Actions
Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Dec 31, 2024
@SenseException SenseException changed the base branch from 2.6 to 3.3.x January 1, 2025 23:24
@SenseException SenseException dismissed greg0ire’s stale review January 1, 2025 23:24

The base branch was changed.

@SenseException SenseException merged commit 68c8774 into doctrine:3.3.x Jan 1, 2025
@SenseException
Copy link
Member

Thank you @CraicOverflow89
Special thanks to the newly added reminder-bot

derrabus added a commit that referenced this pull request Jan 6, 2025
@derrabus
Merge branch '3.3.x' into 3.4.x
327418a 
* 3.3.x:
  Update working-with-objects.rst (#7553)
  changed confusing negative wording (#11775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Majkl578 Majkl578 Majkl578 requested changes

@SenseException SenseException SenseException approved these changes

@deeky666 deeky666 deeky666 approved these changes

@malukenho malukenho malukenho approved these changes

@greg0ire greg0ire greg0ire left review comments

Assignees
No one assigned
Labels
Documentation Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CraicOverflow89 @greg0ire @SenseException @Majkl578 @deeky666 @malukenho @Ocramius